Open SQL tabs for modifying views and triggers #2174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally there should be dialogs for editing views and triggers, but with this feature, users will get a new SQL tab with the necessary statements to recreate the object, so they can edit it and run it easily.
|
To be decided if this little feature enters the next release. It would add three new strings to translate. |
|
Sounds useful. We might as well include it, as having a few extra strings to translate shouldn't be too much hassle. 😄 |
|
Since the 3.12.x branch is already open, we can decide later whether this can be picked there or not. Otherwise, I think this is ready for merging to master, so I'm doing it now. |
|
@mgrojo If you reckon this is safe to cherry-pick across to the 3.12.x branch, lets do it. Same for the other recent PR's too. 😄 |
|
Yes, but let's wait some time so people can play with the nightlies and report any possible glitch. |
|
No worries. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally there should be dialogs for editing views and triggers, but with
this feature, users will get a new SQL tab with the necessary statements
to recreate the object, so they can edit it and run it easily.