Change project file format to support multiple sort columns #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrojo
approved these changes
Oct 29, 2018
There was a problem hiding this comment.
I've reviewed the code changes and test it a bit and haven't seen anything that could be a problem. I think it can be merged.
If this finally enters the 3.11 release, I'll have to update the example described in: https://github.com/sqlitebrowser/sqlitebrowser/wiki/Project-Files
This commit changes the project file format (and some internal data structures) to support multiple sort columns in the Browse Data tab. Note that this does not add actual support for multiple sort columns, it's just a preparation for that.
93aaed9 to
a3e7e83
Compare
|
Thanks for double checking, Manuel! I'll merge this then and cherry-pick it to the v3.11.x branch. I have also already updated the Wiki page (thanks for the reminder!) and fixed the title of the commit message ('suppor' -> 'support') 😉 |
MKleusberg
added a commit
that referenced
this pull request
Oct 30, 2018
This commit changes the project file format (and some internal data structures) to support multiple sort columns in the Browse Data tab. Note that this does not add actual support for multiple sort columns, it's just a preparation for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the project file format (and some internal data
structures) to support multiple sort columns in the Browse Data tab.
Note that this does not add actual support for multiple sort columns,
it's just a preparation for that.
I want to cherry-pick this over to the v3.11.x branch. I think that's pretty handy because for 3.11 we already changed the project file format quite a bit and ask the users to re-save their files. This means these changes here are just on top of that. So when we add support for multiple sort columns one day, we won't have to change the project file format again. However, since the changes here won't get much testing before the release I hope you can have a quick look at the code and check if there are any obvious problems in there 😄