Reset SQL results table when the query has not returned data #1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we know that the just executed query has not returned data, reset the table results model, so the results view is also reset. Added QAbstractItemModel::beginResetModel() and QAbstractItemModel::endResetModel() to the model's reset method. This resets completely the table view. This improves the situation for #1431, without addressing the underlying problem of not detecting correctly the type of query. In any case, any query not returning data should reset the results from previous queries.
|
Agreed, the concept sounds right. 😄 |
|
Yep, seems right. I think the only reason why we didn't clear the table view there was that it's more convenient to view the results of a query and then issue insert/delete/update/... commands based on that without getting your query results removed. But I guess it's causing more confusion than being useful. Also this is why we have added SQL tabs in the meantime. So I'm just going to merge this. I hope nobody minds 😉 Thanks Manuel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we know that the just executed query has not returned data, reset the
table results model, so the results view is also reset.
Added QAbstractItemModel::beginResetModel() and
QAbstractItemModel::endResetModel() to the model's reset method. This
resets completely the table view.
This improves the situation for #1431, without addressing the underlying
problem of not detecting correctly the type of query. In any case, any
query not returning data should reset the results from previous queries.