Remove hardcoded styles from hyperlinks #1286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These hardcoded styles are unnecessary, as Qt will automatically add styling to hyperlinks that matches the system theme.
|
Thanks @oscarwcl. 😄 Yep, this sounds useful. No downsides are really springing to mind either. Looking over the change quickly, nothing pops out as likely bad. Haven't tried compiling it yet though, probably won't today either. Maybe tomorrow, if no-one else has gotten to this already. 😄 |
|
Yep, that really makes sense to change. Thanks, @oscarwcl 😄 |
This was referenced Dec 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These hardcoded styles are unnecessary, as Qt will automatically add styling to hyperlinks that matches the system theme.
This improves compatibility with Qt themes, especially dark themes, where the hardcoded blue hyperlinks are almost unreadable.
Before:
After:
