The Clear All Filters button is converted to a checkable button. #1235
Conversation
When filters are applied, this button clears them as before, but it also saves the current filter values for later restoring. When no filters are applied, it restores the last used filters in the table, if previously saved. The button also provides a visual hint (check state) of whether the filters are applied in any column (they may be out of the view). The icon has been updated in line with the new usage.
|
@mgrojo This is your PR from #1214, with some minor cleanups:
In theory this should be ok for review now. 😄 |
|
Sorry for the delay, I will review this next weekend 😃 |
|
Thank you, @justinclift. The window size and default tab changes were totally unintended. The usual staff performed by qtcreator, that initially I was afraid to undo, thinking it might be needed by the manual changes I've done. I know now that I should revert all those lines. By the way, one or two of my latest commits were performed using the "git pull --rebase". It works like a charm. 😄 |
|
Awesome. 😄 |
|
@mgrojo This PR was superseded by a later one wasn't it? Just thinking we should close this now if it was. 😄 |
|
Yes, with the other PR we can save filters in a more powerful way. We can close this as superseded by #1246 |
|
Cool 😄 I was just starting to write my thoughts about this. So for the record: I can see how it is useful for some use cases but rather irritating for others. Let's say I'm looking up some data in a large table to copy it into some other application. My workflow could be to set some filters to narrow down the table, then copy my field, then hit the clear filters button, and start over with step 1. And then repeat this again and again. That's possible with the current approach (and one reason we added the clear filters button) but doesn't work with the toggle-able (is that a word?) clear filter button. So we would have had to add two buttons or something to have both approaches still working... |
When filters are applied, this button clears them as before,
but it also saves the current filter values for later restoring.
When no filters are applied, it restores the last used filters in
the table, if previously saved.
The button also provides a visual hint (check state) of whether
the filters are applied in any column (they may be out of the
view).
The icon has been updated in line with the new usage.