Add flag expandSelectStar #5813
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaults to false Determines if the compiler rewrites queries to expand `SELECT *` to column names. Update ProjectService.kt
The tests must pass with expandSelectStar set to true for compatibility Update SqlDelightProjectTestCase.kt Update SqlDelightProjectTestCase.kt
59a5054 to
ab0cf11
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flag build/compile time flag
expandSelectStarBooleandefaults tofalseSince #5054 was added - SqlDelight automatically rewrites
SELECT *.This appears to have been added to keep an existing generated schema stable/compatible with a target database schema - where schema columns are added independently - by fixing the columns selected at compile time allows forward compatibility
SqlDelight should not rewrite queries unless the user opts in - as any given Sql must remain un-mutated to avoid surprises to the developer who owns the Sql.
For SqlDelight test cases, the
expandSelectStaris set totruein the build/test environments, as some of these tests were written after the #5054 change and have specific column orderingAdd property
expandSelectStarto common docsTODO - further local testing
CHANGELOG.md's "Unreleased" section has been updated, if applicable.