Skip to content

Conversation

ArminJo
Copy link
Contributor

@ArminJo ArminJo commented Mar 10, 2020

Hello,
I added 2 examples which were very helpful for me tesing and understanding your distance sensor board.

If you want to use GitHub workflow to test compile your library, have a look at my workflow script. If you like it, I can build you a fork with this script for testing.

Best regards
Armin

@AndyEngland521
Copy link
Contributor

Hi @ArminJo , these look pretty slick (who doesn't love a plotter for distance).

Can I get you to bump the version number in library.properties up to 1.2.6 so the Arduino IDE takes note of the differences?

Also, I'm very interested in your workflow script. If you wanted to build us a fork I'd love to give it a look!

Thanks for your hard work,
Andy

@ArminJo
Copy link
Contributor Author

ArminJo commented Mar 10, 2020

Bumping is done.
Armin

@ArminJo
Copy link
Contributor Author

ArminJo commented Mar 10, 2020

And workflow script is added and running successfully :-).

@ArminJo
Copy link
Contributor Author

ArminJo commented Mar 11, 2020

Hello @AndyEngland521
I added a few commits for documentation and for covering more examples for the platforms.
I hope it is OK for you.
It is the first real live test for my build script :-)

Thanks
Armin

@ArminJo
Copy link
Contributor Author

ArminJo commented Mar 17, 2020

Hi Andy,
is there anything I can do?
Or something missing?

Armin

@AndyEngland521
Copy link
Contributor

Hi Armin,
Sorry, things have been quite hectic around here and I was trying to get a minute to show your script to Nate.

@AndyEngland521 AndyEngland521 merged commit 298d23b into sparkfun:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants