Skip to content

fix: processor checks inconsistently problem #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

halx99
Copy link
Contributor

@halx99 halx99 commented Dec 2, 2024

Our tests check whether you have introduced trailing white space. If such a test fails, please check the "artifacts button" above, which if you click it gives a link to a downloadable file to help you identify the issue. You can also run scripts/remove_trailing_whitespace.sh locally if you have a bash shell and the sed command available on your system.

If you plan to contribute to simdjson, please read our

CONTRIBUTING guide: https://github.com/simdjson/simdjson/blob/master/CONTRIBUTING.md and our
HACKING guide: https://github.com/simdjson/simdjson/blob/master/HACKING.md

@halx99 halx99 force-pushed the unify-processor-checks branch from a3998ad to 0a380b5 Compare December 2, 2024 17:25
@lemire
Copy link
Member

lemire commented Dec 2, 2024

The singleheader files are generated automatically, so you should not have edited them, but it should not be a problem.

I see some Windows failure, but they are not related to this PR and are rather related to the removal of some legacy support on GitHub's infrastructure.

I will let the tests run and I expect to merge this PR.

@lemire lemire merged commit 79126ca into simdjson:master Dec 3, 2024
73 of 74 checks passed
@lemire
Copy link
Member

lemire commented Dec 3, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants