Make document::is_null behavior consistent with documentation #2258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the docs: `INCORRECT_TYPE If the JSON value begins with 'n' and is not 'null'.`
|
Looks reasonable!!! |
|
Merging. This will be part of the next release. |
|
Thanks! |
tobil4sk
added a commit
to tobil4sk/lua-simdjson
that referenced
this pull request
Sep 24, 2024
For now, we can just manually throw the exception until the next simdjson bugfix release: simdjson/simdjson#2258
FourierTransformer
pushed a commit
to FourierTransformer/lua-simdjson
that referenced
this pull request
Sep 26, 2024
* Enable tests for invalid documents starting with n * Add test for invalid document with trailing text Oddly, `null trailing` gives an error, but `nully trailing` does not * Add workaround for scalar document is_null bug For now, we can just manually throw the exception until the next simdjson bugfix release: simdjson/simdjson#2258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function documentation states:
INCORRECT_TYPE If the JSON value begins with 'n'and is not 'null'., however, it previously failed to return any error.The behavior has now been corrected and the unit test updated.