Skip to content

deps: switch to CPM #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 20, 2024
Merged

deps: switch to CPM #2257

merged 4 commits into from
Sep 20, 2024

Conversation

lemire
Copy link
Member

@lemire lemire commented Sep 18, 2024

The simdjson library uses its own custom dependency management system. This PR would switch it to CPM.

Note that CPM has advanced features, far beyond what we support.

cc @the-moisrex

@the-moisrex
Copy link
Member

The good thing about CPM is that even if we do a CPM_SOURCE_CACHE=~/.cache/CPM, CPM stores it in hashed directories, but in the previous way the the dependencies were updated, but CMake didn't somehow update the cache.

So, I agree with using CPM.

@lemire
Copy link
Member Author

lemire commented Sep 18, 2024

So, I agree with using CPM.

I'll merge once it goes green.

@lemire
Copy link
Member Author

lemire commented Sep 20, 2024

It is green!!!

@lemire lemire merged commit 6c979f1 into master Sep 20, 2024
131 checks passed
@lemire lemire deleted the switch_to_cpm branch September 20, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants