-
Notifications
You must be signed in to change notification settings - Fork 2.7k
chore: include a minimal image for vlms when warming-up #9528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @mickqian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the SGLang server's handling of Vision-Language Models (VLMs) by implementing a more robust warmup procedure and improving model capability reporting. It introduces a minimal image for VLM warmup requests, ensuring that multimodal components are properly initialized. Furthermore, the server's API now provides explicit flags to indicate whether a model possesses image or audio understanding capabilities. The changes also include refactoring of vision attention mechanisms for better maintainability and accuracy, alongside the addition of temporary debug prints to aid in development.
Highlights
- VLM Warmup with Minimal Image: The PR introduces a minimal 1x1 black PNG image, base64 encoded, to be used during the warmup phase for Vision-Language Models (VLMs). This ensures that VLM-specific pathways are properly initialized and ready for multimodal requests.
- Model Capability Exposure: The
get_model_info
API now exposes new flags,has_image_understanding
andhas_audio_understanding
, allowing clients to programmatically determine if a loaded model supports image or audio processing capabilities. - Vision Attention Refactoring: The logic for converting Hugging Face attention backend configurations to SGLang's internal QKV backend types has been extracted into a dedicated utility function. Additionally, the vision attention mechanism now correctly handles and utilizes
max_seqlen
for mask generation, improving attention mask handling. - Temporary Debugging Prints: Several temporary print statements (e.g., "0000", "1111", "22222", "333333") have been added across different files, likely for debugging purposes related to request handling and disaggregation modes.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for warming up Vision Language Models (VLMs) with a minimal image and exposes model capabilities for image and audio understanding via an API endpoint. The changes are well-structured, including a nice refactoring in the vision attention layer. My review includes suggestions to remove some leftover debug print statements and to simplify a redundant conditional block for better code clarity and maintainability.
Motivation
has_image_understanding
inget_model_info
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist