-
Couldn't load subscription status.
- Fork 672
feat(java): improved types, structure and serialization #7145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 1d5f6f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Scalar CDN Snapshot Diff ResultsDetails
Failed teststest-snapshots/snapshot.e2e.ts › Diff with CDN - Scalar Galaxy Important These tests detect visual differences between the current PR and the latest CDN build which means they may be affected by other changes in They can help determine if the changes in the PR are causing any unexpected visual regressions but may be less helpful in isolating the exact cause. For more details see the readme. |
Scalar Components Snapshot Test ResultsDetails
|
Scalar Docs PreviewProject Commit Status Preview Updated (UTC): Oct 27, 2025, 8:11 AM To edit notification comments on pull requests, go to your Scalar project settings |
ae9b954 to
e5965ac
Compare
e5965ac to
53dfe66
Compare
WIP
Currently not working:
Problem
Our current Java integration lacks several configuration properties and doesn’t consistently use type-safe structures.
Solution
This PR introduces several improvements:
ScalarTheme) to ensure stronger type safety.ScalarClientandScalarTargetenums (like in our .NET integration).AbstractScalarControllerclass as a base class for other controllers.ConfigureProperties()method inAbstractScalarController, allowing configuration updates before JSON serialization.The following string-based properties have been replaced with enum-based properties:
themefield andgetTheme()/setTheme()methodslayoutfield andgetLayout()/setLayout()methodsdocumentDownloadTypefield andgetDocumentDownloadType()/setDocumentDownloadType()methodsThe
ScalarSourceclass has been moved from a nested class inScalarPropertiesto a standalone class in theconfigpackage:com.scalar.maven.webjar.ScalarProperties.ScalarSourcecom.scalar.maven.webjar.config.ScalarSourceChecklist
I've gone through the following:
pnpm changeset).