Skip to content

Introduce specific error for unsupported signatures #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Introduce specific error for unsupported signatures #2479

merged 1 commit into from
Jun 3, 2025

Conversation

@ctz
Copy link
Member

@ctz ctz commented Jun 2, 2025

BadSignature convolves two cases with different causes: a genuinely bad signature, where we positively identified that a signature was incorrect; and where we don't support a signature algorithm and can't say whether it was valid or not.

@ctz
Introduce specific error for unsupported signatures
e57cd8f 
`BadSignature` convolves two cases with different causes: a genuinely bad signature,
where we positively identified that a signature was incorrect; and where
we don't support a signature algorithm and can't say whether it was valid or not.
@rustls-benchmarking
Copy link

rustls-benchmarking bot commented Jun 2, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3599950 3586508 ✅ -13442 (-0.37%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9923646 9949181 25535 (0.26%) 0.87%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11556333 11580543 24210 (0.21%) 1.26%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10470981 10461888 -9093 (-0.09%) 1.16%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3303453 3305793 2340 (0.07%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9948418 9955355 6937 (0.07%) 0.60%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78750819 78696570 -54249 (-0.07%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304325 3302284 -2041 (-0.06%) 0.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4752369 4749922 -2447 (-0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11564801 11558913 -5888 (-0.05%) 1.32%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56607684 56580553 -27131 (-0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2004419 2003469 -950 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78461721 78434408 -27313 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78490340 78510519 20179 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78691656 78672199 -19457 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55212226 55198625 -13601 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4749731 4748601 -1130 (-0.02%) 0.94%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78698057 78680200 -17857 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78450532 78467228 16696 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78539949 78555256 15307 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55286999 55297311 10312 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56560180 56550552 -9628 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56591041 56582011 -9030 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55215246 55223690 8444 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78707661 78696164 -11497 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55301207 55308967 7760 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2904919 2904549 -370 (-0.01%) 0.84%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3580406 3579984 -422 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3877921 3877471 -450 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78436489 78427608 -8881 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78725884 78717468 -8416 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4220016 4219566 -450 (-0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4308520 4308070 -450 (-0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4572138 4571688 -450 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78520542 78514220 -6322 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55211446 55207032 -4414 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56603551 56599204 -4347 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56558213 56553871 -4342 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001740 2001602 -138 (-0.01%) 1.19%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55298981 55295894 -3087 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78671219 78669096 -2123 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2907481 2907539 58 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56548406 56547296 -1110 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719947 1719920 -27 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246529 2246502 -27 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296475 1296488 13 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334276 2334258 -18 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339925 2339907 -18 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295296 1295291 -5 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7222963 7222973 10 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736367 34736335 -32 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34738038 34738031 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46448256 46448263 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452696 46452703 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58123155 58123161 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80538690 80538682 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668623 92668614 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80543182 80543189 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397771 46397767 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46459280 46459276 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637666 80637660 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157979 58157975 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58257398 58257402 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284265 46284262 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92691084 92691090 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92697228 92697222 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92699461 92699455 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92723313 92723319 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58235446 58235449 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294222 46294220 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92659489 92659485 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58130365 58130367 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154766 58154764 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80643597 80643595 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189286 46189285 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46289087 46289086 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58037346 58037347 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58232571 58232572 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533872 80533871 -1 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31233927 31233927 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31986490 31986490 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31158668 31158668 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30837059 30837059 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31162656 31162656 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5009710 5009710 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32449953 32449953 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31229939 31229939 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32551863 32551863 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31155335 31155335 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31226585 31226585 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80632585 80632585 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32452762 32452762 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4758564 4758564 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32111192 32111192 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30935328 30935328 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30839984 30839984 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32111325 32111325 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10999803 10999803 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4299226 4299226 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32554630 32554630 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133715 11133715 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32452720 32452720 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32108140 32108140 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30931274 30931274 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7221012 7221012 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30928349 30928349 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11127954 11127954 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32554672 32554672 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30844038 30844038 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31989675 31989675 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31989542 31989542 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867921 3867921 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.71 ms 4.63 ms -0.07 ms (-1.58%) 6.94%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.35 ms 5.28 ms -0.07 ms (-1.39%) 6.16%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.41 ms 5.33 ms -0.08 ms (-1.39%) 5.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 654.62 µs 645.98 µs -8.64 µs (-1.32%) 3.79%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.07 ms 5.00 ms -0.07 ms (-1.32%) 6.27%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.80 ms 1.78 ms -0.02 ms (-1.28%) 3.21%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.40 ms 5.33 ms -0.07 ms (-1.27%) 5.98%
transfer_no_resume_ring_1.3_rsa_aes 5.89 ms 5.82 ms -0.07 ms (-1.21%) 5.66%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.81 ms 10.69 ms -0.12 ms (-1.15%) 1.38%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.64 ms 10.52 ms -0.12 ms (-1.13%) 1.54%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.47 ms 11.35 ms -0.13 ms (-1.10%) 1.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 652.45 µs 645.40 µs -7.05 µs (-1.08%) 4.01%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.30 ms 11.18 ms -0.12 ms (-1.06%) 1.33%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.58 ms 10.47 ms -0.11 ms (-1.06%) 1.28%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.51 ms 11.39 ms -0.12 ms (-1.06%) 1.28%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.43 ms 11.31 ms -0.12 ms (-1.04%) 1.28%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.24 ms 11.13 ms -0.12 ms (-1.03%) 1.27%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.63 ms 1.62 ms -0.02 ms (-1.02%) 2.73%
transfer_no_resume_ring_1.2_rsa_aes 5.83 ms 5.78 ms -0.06 ms (-1.02%) 5.34%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.76 ms 10.65 ms -0.11 ms (-1.02%) 1.63%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.45 ms 11.33 ms -0.12 ms (-1.01%) 1.12%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.32 ms 11.21 ms -0.11 ms (-0.98%) 1.34%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.59 ms -0.01 ms (-0.93%) 1.60%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.25 ms 11.15 ms -0.10 ms (-0.92%) 1.32%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.50 ms 8.44 ms -0.07 ms (-0.80%) 3.18%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.18 ms 13.09 ms -0.09 ms (-0.66%) 2.51%
handshake_no_resume_ring_1.3_ecdsap256_aes 465.27 µs 462.26 µs -3.01 µs (-0.65%) 4.03%
handshake_no_resume_ring_1.3_ecdsap256_chacha 462.91 µs 460.16 µs -2.75 µs (-0.59%) 3.41%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.51 ms -0.01 ms (-0.58%) 1.09%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.30 ms 1.30 ms -0.01 ms (-0.57%) 1.48%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.82 ms 13.75 ms -0.08 ms (-0.56%) 2.12%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.96 ms 12.89 ms -0.07 ms (-0.54%) 2.24%
transfer_no_resume_ring_1.3_rsa_chacha 13.46 ms 13.39 ms -0.07 ms (-0.53%) 2.42%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.30 ms 1.29 ms -0.01 ms (-0.52%) 1.90%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.86 ms 13.79 ms -0.07 ms (-0.50%) 2.34%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms -0.01 ms (-0.47%) 1.81%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.06 ms 15.99 ms -0.07 ms (-0.42%) 1.78%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.49 ms 5.47 ms -0.01 ms (-0.20%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.05 ms 6.03 ms -0.01 ms (-0.20%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.08 ms 6.07 ms -0.01 ms (-0.17%) 1.04%
handshake_tickets_ring_1.3_ecdsap256_aes 5.59 ms 5.58 ms -0.01 ms (-0.16%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.55 ms 5.54 ms -0.01 ms (-0.16%) 1.37%
handshake_no_resume_ring_1.3_rsa_aes 955.91 µs 954.50 µs -1.40 µs (-0.15%) 1.60%
handshake_session_id_ring_1.3_ecdsap256_aes 5.51 ms 5.51 ms -0.01 ms (-0.14%) 1.29%
handshake_no_resume_ring_1.3_rsa_chacha 955.61 µs 954.32 µs -1.29 µs (-0.13%) 1.67%
handshake_session_id_ring_1.3_rsa_aes 6.02 ms 6.01 ms -0.01 ms (-0.13%) 1.06%
handshake_tickets_ring_1.3_ecdsap384_aes 8.68 ms 8.67 ms -0.01 ms (-0.12%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 951.83 µs 950.70 µs -1.13 µs (-0.12%) 1.26%
handshake_session_id_ring_1.3_rsa_chacha 5.98 ms 5.97 ms -0.01 ms (-0.10%) 1.15%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.56 ms 3.56 ms -0.00 ms (-0.09%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.56 ms 3.56 ms -0.00 ms (-0.08%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.34 ms 1.34 ms -0.00 ms (-0.07%) 1.72%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.64 ms 8.64 ms -0.01 ms (-0.06%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.33 ms 1.33 ms 0.00 ms (0.03%) 1.69%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.58 ms 8.57 ms -0.00 ms (-0.02%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.61 ms 8.61 ms -0.00 ms (-0.00%) 1.00%

Additional information

Historical results

Checkout details:

@codecov
Copy link

codecov bot commented Jun 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.43%. Comparing base (2e7f326) to head (e57cd8f).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2479   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files          97       97           
  Lines       21959    21966    +7     
=======================================
+ Hits        20956    20963    +7     
  Misses       1003     1003

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

djc
djc reviewed Jun 3, 2025
View reviewed changes
@ctz ctz mentioned this pull request Jun 3, 2025
Closed
@ctz ctz enabled auto-merge June 3, 2025 07:58
@ctz ctz added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit 19133f2 Jun 3, 2025
34 checks passed
@ctz ctz deleted the jbp-unsupported-sig-alg branch June 3, 2025 08:43
@ctz ctz linked an issue Jun 5, 2025 that may be closed by this pull request
TLS 1.2 handshake fails with ⁠ecdsa_secp521r1_sha512 (Invalid peer certificate: ⁠BadSignature) #2477
Closed
1 task
@cpu cpu mentioned this pull request Jun 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TLS 1.2 handshake fails with ⁠ecdsa_secp521r1_sha512 (Invalid peer certificate: ⁠BadSignature)

3 participants

@ctz @djc @cpu