Skip to content

fix: ensure server-initiated requests include a valid request_id #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025

Conversation

hashemix
Copy link
Member

📌 Summary

This PR fixes an issue where server-initiated requests were being sent without a valid request_id, which caused an assertion error. The fix ensures that a new request_id is always generated for server-initiated requests.

✨ Changes Made

  • Updated send() to guarantee that server-initiated requests always generate a valid request_id.
  • Replaced RwLock with tokio::sync::watch in set_client_details() for more efficient state updates.
  • Added a new wait_for_initialization() function that allows awaiting the completion of the server initialization process (when used).

@hashemix hashemix merged commit 5f9a966 into main Aug 15, 2025
3 checks passed
@hashemix hashemix mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant