Add codegen-llvm regression tests #145380
Merged
+182
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
Mark-Simulacrum
requested changes
Aug 21, 2025
| // CHECK-LABEL: @is_inter_or_switch | ||
| #[no_mangle] | ||
| pub fn is_inter_or_switch(f: FrameType) -> bool { | ||
| // CHECK-NOT: ADD |
There was a problem hiding this comment.
This feels a little brittle -- maybe we should check a more specific sequence of instructions? Or some other form of assertion that's not "no adds".
There was a problem hiding this comment.
Sure, I can change this to the specific sequence of checking and-cmp-ret in addition to the check-not.
This was the IR change from that issue, the subtraction being unwanted.
define i1 @src(i8 range(i8 0, 4) %arg) {
- %add = add nsw i8 %arg, -1
%and = and i8 %add, -3
%cmp = icmp eq i8 %and, 0
ret i1 %cmp
}| #[no_mangle] | ||
| pub fn check_no_compare(v: &mut Vec<f32>) { | ||
| // CHECK-NOT: icmp | ||
| // CHECK-NOT: br |
There was a problem hiding this comment.
This also seems brittle -- I could see a future compiler making this just call Vec::clear (given that the code sequence is the same for all 4-byte vec values, and maybe even for all T: Copy vec values?).
There was a problem hiding this comment.
I'm not sure what to do so I'll back this test out then.
1.29 codegen - https://rust.godbolt.org/z/9qcPPMh67
1.30 codegen - https://rust.godbolt.org/z/7qK1rojYG
Most of these regressions concern elimination of panics and bounds checks that were fixed upstream by LLVM.
b109232 to
9e28de2
Compare
|
I removed the vec clear test and that issue from the PR message. @rustbot ready |
|
@bors r+ rollup=iffy |
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 22, 2025
…Simulacrum Add codegen-llvm regression tests Most of these regressions deal with elimination of panics and bounds checks that were fixed upstream by LLVM. closes rust-lang#141497 closes rust-lang#131162 closes rust-lang#129583 closes rust-lang#110971 closes rust-lang#91109 closes rust-lang#80075 closes rust-lang#74917 closes rust-lang#71997 closes rust-lang#71257 closes rust-lang#59352
bors
added a commit
that referenced
this pull request
Aug 23, 2025
Rollup of 20 pull requests Successful merges: - #132087 (Fix overly restrictive lifetime in `core::panic::Location::file` return type) - #137396 (Recover `param: Ty = EXPR`) - #142185 (Convert moves of references to copies in ReferencePropagation) - #144443 (Make target pointer width in target json an integer) - #144648 (Implementation: `#[feature(nonpoison_rwlock)]`) - #144897 (print raw lifetime idents with r#) - #145218 ([Debuginfo] improve enum value formatting in LLDB for better readability) - #145380 (Add codegen-llvm regression tests) - #145573 (Add an experimental unsafe(force_target_feature) attribute.) - #145597 (resolve: Remove `ScopeSet::Late`) - #145641 (On E0277, point at type that doesn't implement bound) - #145669 (rustdoc-search: GUI tests check for `//` in URL) - #145695 (Introduce ProjectionElem::try_map.) - #145710 (Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64) - #145726 (Experiment: Reborrow trait) - #145731 (Make raw pointers work in type-based search) - #145736 (triagebot: Update style team reviewers) - #145738 (Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures.) - #145743 (doc: fix some typos in comment) - #145745 (tests: Ignore basic-stepping.rs on LoongArch) Failed merges: - #145670 (port `sanitize` attribute to the new parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Aug 23, 2025
Rollup of 28 pull requests Successful merges: - #132087 (Fix overly restrictive lifetime in `core::panic::Location::file` return type) - #137396 (Recover `param: Ty = EXPR`) - #137457 (Fix host code appearing in Wasm binaries) - #142185 (Convert moves of references to copies in ReferencePropagation) - #144648 (Implementation: `#[feature(nonpoison_rwlock)]`) - #144897 (print raw lifetime idents with r#) - #145218 ([Debuginfo] improve enum value formatting in LLDB for better readability) - #145380 (Add codegen-llvm regression tests) - #145573 (Add an experimental unsafe(force_target_feature) attribute.) - #145597 (resolve: Remove `ScopeSet::Late`) - #145633 (Fix some typos in LocalKey documentation) - #145641 (On E0277, point at type that doesn't implement bound) - #145669 (rustdoc-search: GUI tests check for `//` in URL) - #145695 (Introduce ProjectionElem::try_map.) - #145710 (Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64) - #145726 (Experiment: Reborrow trait) - #145731 (Make raw pointers work in type-based search) - #145736 (triagebot: Update style team reviewers) - #145738 (Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures.) - #145742 (rustdoc js: Even more typechecking improvments ) - #145743 (doc: fix some typos in comment) - #145745 (tests: Ignore basic-stepping.rs on LoongArch) - #145747 (Refactor lint buffering to avoid requiring a giant enum) - #145751 (fix(lexer): Allow '-' in the frontmatter infostring continue set) - #145761 (Add aarch64_be-unknown-hermit target) - #145762 (convert strings to symbols in attr diagnostics) - #145763 (Ship LLVM tools for the correct target when cross-compiling) - #145765 (Revert suggestions for missing methods in tuples) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Aug 23, 2025
Rollup merge of #145380 - okaneco:add-codegen-tests, r=Mark-Simulacrum Add codegen-llvm regression tests Most of these regressions deal with elimination of panics and bounds checks that were fixed upstream by LLVM. closes #141497 closes #131162 closes #129583 closes #110971 closes #91109 closes #80075 closes #74917 closes #71997 closes #71257 closes #59352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these regressions deal with elimination of panics and bounds checks that were fixed upstream by LLVM.
closes #141497
closes #131162
closes #129583
closes #110971
closes #91109
closes #80075
closes #74917
closes #71997
closes #71257
closes #59352