Skip to content

Add strip code to the left and right for long lines #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 28, 2020
Merged

Add strip code to the left and right for long lines #36

merged 3 commits into from
Jun 28, 2020

Conversation

zzau13
Copy link
Contributor

@zzau13 zzau13 commented Jun 13, 2020 •
edited
Loading

Closes #8
Is the same Margin as rustc but zero copy

Closes #35

@zzau13 zzau13 marked this pull request as draft June 13, 2020 18:32
@zzau13 zzau13 marked this pull request as ready for review June 13, 2020 19:16
@zbraniecki zbraniecki self-requested a review June 24, 2020 07:21
zbraniecki
zbraniecki approved these changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@zbraniecki zbraniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great. I apologize for a long review cycle! Will improve! :)

@zbraniecki zbraniecki merged commit ff009fb into rust-lang:master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@zbraniecki zbraniecki zbraniecki approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

README and docs reference non existent DisplayListFormatter Strip code to the left and right in diagnostics for long lines
2 participants
@zzau13 @zbraniecki