GH-439 move avatar into view component #930
Conversation
57c51fb to
309be6c
Compare
309be6c to
a3505f6
Compare
|
|
It is now ready for review |
| <%= content_tag :span, class: text_size do %> | ||
| <%= avatarable.name.split(" ").map(&:first).join %> | ||
| <% end %> |
There was a problem hiding this comment.
Can we always render the initials so that when the image fails to load that we can fall back to the initials?
We had this in some places where we had onerror="this.remove()" on the <img> tags which then revealed the initials if it failed to load.
There was a problem hiding this comment.
This aleady looks great, thanks for working on this @aronwolf90! 🙏🏼
We also have this page here: https://www.rubyevents.org/components
Would you mind adding your new component in all sizes/variants (image, initials, custom content) to that page too? Thank you!
Ticket: GH-439
NOTE: there are some changes in the size and colors to make avatars more consistent.
For example