Refactoring TalksAgent to use active agent #890
Conversation
… view style prompt message template rendering
5e68f6e to
236a320
Compare
|
|
||
| 1. First, review the metadata of the video: | ||
| <metadata> | ||
| - title: #{title} |
There was a problem hiding this comment.
These interpolations won't work in ERB files
There was a problem hiding this comment.
Indeed this needs to be updated and tested still, thanks for pointing this out.
| @@ -0,0 +1,22 @@ | |||
| <%= { | |||
There was a problem hiding this comment.
Is there a reason why this is in ERB and in a separate file if it's just a Ruby hash anyway?
There was a problem hiding this comment.
Separate file to separate of concerns, but doesn't have to be erb, though I have been using erb to render things like action names dynamically.
| def update_topics | ||
| raw_response = JSON.repair(response.dig("choices", 0, "message", "content")) | ||
| topics = begin | ||
| JSON.parse(raw_response)["topics"] |
There was a problem hiding this comment.
I feel like this should either be directly handled in the framework or maybe the schema needs to be updated?
Isn't the whole idea of structured output that it gives you JSON back?
There was a problem hiding this comment.
Yeah, this also needs testing, I mostly wanted to show how it will look overall compared to how it was before. That way I could get your feedback before spending too much time on it.
|
Hello thanks for working on this proposal. Just a quick heads up that this part of the code has been working quite well for us up to now and I kind of liked the combination of ActiveJob-performs and associated object we ended up using. At this point of the PR I don't really see a clear benefits of introducing a new dependency/framework. I am following ActiveAgent development I feel like it is made for more complex Agent workflows and we are not there yet our usage is very simple and I think will remain simple for quite some time. If we where to introduce a new framework I would prefer that this happens on some new feature where it really brings something new to the table but happy to be convinced otherwise |
|
I appreciate your perspective and the old adage of don't fix what isn't broken certainly applies to your sentiments. I was planning to start with this conversion/refactor as a POC for what you already have as an example of how active agent could be used to make even simple use cases more concise. The ultimate goal would be to continue on to having more advanced agent feature sets for collecting talks, events, and sponsors data. Let me know if you'd like to discuss this proposal/draft PR more or if there is any interest in continuing down this path. |
Refactoring TalksAgent to use active agent's action prompt for action… view style prompt message template rendering