Skip to content

Add test to check encoding for empty string #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2024
Merged

Add test to check encoding for empty string #80

merged 1 commit into from
Jan 14, 2024

Conversation

@naitoh
Copy link
Contributor

@naitoh naitoh commented Jan 14, 2024 •
edited
Loading

Add test to check encoding for empty string

See: #78 (comment)

@naitoh naitoh mentioned this pull request Jan 14, 2024
Closed
@headius headius mentioned this pull request Jan 14, 2024
Merged
@headius
Copy link
Contributor

headius commented Jan 14, 2024

I've confirmed the changes in #79 make these tests pass on JRuby. @mrkn You can decide whether to merge as-is or to rebase.

@mrkn
Copy link
Member

mrkn commented Jan 14, 2024

@headius Thank you for the confirmation on JRuby :)
@naitoh could you please rebase and force push this branch?

@naitoh naitoh force-pushed the add_test_to_check_encoding_for_empty_string branch from d57f9b2 to cc66e10 Compare January 14, 2024 11:47
@naitoh
Copy link
Contributor Author

naitoh commented Jan 14, 2024

@mrkn
I have done rebase and force push.

kou
kou reviewed Jan 14, 2024
View reviewed changes
@naitoh naitoh force-pushed the add_test_to_check_encoding_for_empty_string branch from cc66e10 to e783ba7 Compare January 14, 2024 12:20
@kou kou merged commit d050851 into ruby:master Jan 14, 2024
@kou
Copy link
Member

kou commented Jan 14, 2024

Thanks both!

@naitoh naitoh deleted the add_test_to_check_encoding_for_empty_string branch January 14, 2024 12:31
matzbot pushed a commit to ruby/ruby that referenced this pull request Jan 19, 2024
@naitoh @hsbt
[ruby/strscan] Add test to check encoding for empty string
91f3530 
(ruby/strscan#80)

See: ruby/strscan#78 (comment)

ruby/strscan@d0508518a9
@headius headius mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@naitoh @headius @mrkn @kou