Skip to content

JRuby extension: drop old-Joni-version support #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 14, 2024
Merged

JRuby extension: drop old-Joni-version support #76

merged 4 commits into from
Jan 14, 2024

Conversation

@olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Jan 10, 2024 •
edited
Loading

This PR removes the code path for OldRegionAdapter, now that all published JRuby versions are using "new API" for Region, so no adapting is necessary.

Details

headius mentioned in an off-GitHub conversation:

Yeah we had a transition period where it supported both old and new
but now all released JRuby should be on the new version

(Using Region) should be fine, especially since 9.3 can't really install the gem (it will be ignored unless explicitly activated) and 9.4 has had the new region logic for several releases

TODO

  • Remove the Interface, and use Region as-is.
  • Remove the usage of the intermediate interface

@olleolleolle
JRuby extension: drop old-Joni-version support
d2d5722 
This removes the code path for OldRegionAdapter.

headius mentioned in an off-GitHub conversation:
> Yeah we had a transition period where it supported both old and new
but now all released JRuby should be on the new version
@olleolleolle olleolleolle mentioned this pull request Jan 10, 2024
Merged
@olleolleolle olleolleolle marked this pull request as ready for review January 12, 2024 19:57
@olleolleolle olleolleolle requested a review from headius January 12, 2024 19:57
@headius
Copy link
Contributor

headius commented Jan 13, 2024

Expanding my reply to @olleolleolle:

  • JRuby versions prior to JRuby 9.4 will not use the gem if it is not explicitly activated, since they bundled it as a non-gem part of stdlib.
  • JRuby 9.2 and earlier will break if this gem is upgraded and activated, but we believe there are few applications still using 9.2 that could not easily be upgraded to 9.3 or 9.4.
  • JRuby 9.3.11.0 and newer all ship with the updated joni logic and can support the gem without the legacy code.

I think this is fine to do. It's not a commonly upgraded gem, and even if it does get upgraded, JRuby has supported these APIs for several months.

@enebo Any concerns?

1 similar comment
@headius

This comment was marked as duplicate.

Sign in to view
headius
headius approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@headius headius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@headius headius merged commit c6804b7 into ruby:master Jan 14, 2024
@olleolleolle olleolleolle deleted the jruby-drop-old-joni-support branch January 14, 2024 14:06
@olleolleolle olleolleolle mentioned this pull request Jan 15, 2024
Closed
@olleolleolle olleolleolle linked an issue Jan 15, 2024 that may be closed by this pull request
CI is broken on latest JRuby #75
Closed
@headius headius mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@headius headius headius approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI is broken on latest JRuby

2 participants

@olleolleolle @headius