jruby: Pass end index to byteListToInum #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we release a new version soon? |
|
@kou If it's convenient, that would be great! I don't have any other changes coming right now. Also I think this fixes the matrix for windows-latest and "jruby", because the released "jruby" now is JRuby 10 and requires Java 21+: diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7890e97..6034394 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -45,7 +45,7 @@ jobs:
distribution: zulu
java-version: 21
if: >-
- matrix.ruby == 'jruby-head'
+ startWith(matrix.ruby, 'jruby')
- name: Set up Ruby
uses: ruby/setup-ruby@v1 |
|
Could you open a new PR for the CI change? |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
May 8, 2025
(ruby/strscan#150) These parse methods take begin and end indices, not begin and length. A test is included. Fixes jruby/jruby#8823 ruby/strscan@9690e39e73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These parse methods take begin and end indices, not begin and length. A test is included.
Fixes jruby/jruby#8823