Skip to content

Fix a bug that inconsistency of IndexError vs nil for unknown capture group #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2025
Merged

Fix a bug that inconsistency of IndexError vs nil for unknown capture group #143

merged 1 commit into from
Feb 23, 2025

Conversation

@naitoh
Copy link
Contributor

@naitoh naitoh commented Feb 22, 2025

Fix GH-139

kou
kou reviewed Feb 23, 2025
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have scanner.scan("not-matched") case?

@naitoh naitoh force-pushed the fix_IndexError_for_unknown_capture_group branch 2 times, most recently from 98ca322 to 48a7359 Compare February 23, 2025 03:30
@naitoh
Copy link
Contributor Author

naitoh commented Feb 23, 2025

Do we have scanner.scan("not-matched") case?

Added.

In the not-matched case, nil return without exception.
But since the results of Regexp pattern and String pattern are the same, so I think no problem.

@naitoh naitoh requested a review from kou February 23, 2025 04:00
kou
kou reviewed Feb 23, 2025
View reviewed changes
@naitoh naitoh force-pushed the fix_IndexError_for_unknown_capture_group branch from 48a7359 to e515324 Compare February 23, 2025 05:48
@naitoh naitoh requested a review from kou February 23, 2025 06:01
@kou kou merged commit bc8a0d2 into ruby:master Feb 23, 2025
40 checks passed
@kou
Copy link
Member

kou commented Feb 23, 2025

Thanks.

@naitoh naitoh deleted the fix_IndexError_for_unknown_capture_group branch February 23, 2025 07:57
hsbt pushed a commit to hsbt/ruby that referenced this pull request Feb 25, 2025
@naitoh @hsbt
[ruby/strscan] Fix a bug that inconsistency of IndexError vs nil for
38882ea 
unknown capture group
(ruby/strscan#143)

Fix ruby/strscan#139

Reported by Benoit Daloze. Thanks!!!

ruby/strscan@bc8a0d2623
hsbt pushed a commit to ruby/ruby that referenced this pull request Feb 25, 2025
@naitoh @hsbt
[ruby/strscan] Fix a bug that inconsistency of IndexError vs nil for
018943b 
unknown capture group
(ruby/strscan#143)

Fix ruby/strscan#139

Reported by Benoit Daloze. Thanks!!!

ruby/strscan@bc8a0d2623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou Awaiting requested review from kou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistency of IndexError vs nil for unknown capture group

2 participants

@naitoh @kou