Fix a bug that scanning methods that don't use Regexp don't clear named capture groups #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Feb 22, 2025
kou
reviewed
Feb 22, 2025
2b814b2 to
56368c2
Compare
kou
reviewed
Feb 22, 2025
test/strscan/test_stringscanner.rb
Outdated
| end | ||
|
|
||
| def test_string | ||
| omit("not implemented on TruffleRuby") if ["truffleruby"].include?(RUBY_ENGINE) |
There was a problem hiding this comment.
Can we use RUBY_ENGINE == "truffleruby" like existing code?
Suggested change
| omit("not implemented on TruffleRuby") if ["truffleruby"].include?(RUBY_ENGINE) | |
| omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby" |
ext/strscan/strscan.c
Outdated
| #define MATCHED(s) ((s)->flags |= FLAG_MATCHED) | ||
| #define CLEAR_MATCHED(s) ((s)->flags &= ~FLAG_MATCHED) | ||
| #define CLEAR_NAMED_CAPTURES(s) ((s)->regex = Qnil) | ||
| #define CLEAR_MATCHED_AND_NAMED_CAPTURES(s) CLEAR_MATCHED(s); CLEAR_NAMED_CAPTURES(s) |
There was a problem hiding this comment.
Can we use better name (more logical name) for this?
If we rename existing CLEAR_MATCH_STATUS() to CLEAR_MATCHED(), we may be able to use CLEAR_MATCH_STATUS() for CLEAR_MATCHED_AND_NAMED_CAPTURES().
Could you use while {statement1; statment2; ...} do (false) when you want to use multiple statements in a macro?
See also:
Lines 72 to 75 in c4e4795
…ed capture groups Fix rubyGH-135
56368c2 to
38ef27a
Compare
|
Thanks. |
hsbt
pushed a commit
to hsbt/ruby
that referenced
this pull request
Feb 25, 2025
don't clear named capture groups (ruby/strscan#142) Fix ruby/strscan#135 ruby/strscan@b957443e20
hsbt
pushed a commit
to ruby/ruby
that referenced
this pull request
Feb 25, 2025
don't clear named capture groups (ruby/strscan#142) Fix ruby/strscan#135 ruby/strscan@b957443e20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GH-135