Pre-mark classes as shareable #14288
Open
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classes are supposed to be always shareable. It's better for us to eagerly allocate them this way, otherwise we end up unsafely concurrently mutating their flags.
❌ Tests Failed✖️no tests failed ✔️62268 tests passed(1 flake) |
|
Thank you!! I already has completely same patch with newly introducing macro, so could you wait for it? |
|
Sure! It's no problem to wait. This solves a TSAN error, but to my knowledge isn't yet causing wider issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes are supposed to be always shareable. It's better for us to eagerly allocate them this way, otherwise we end up unsafely concurrently mutating their flags.
cc @ko1