Skip to content

Conversation

@eregon
Copy link
Member

@eregon eregon commented Nov 30, 2023

No description provided.

* Data#members might not be defined, instead it might be defined
  on Data subclasses or a module included there. This is notably the
  case on TruffleRuby which defines it there for optimization purposes.
  In fact the mere presence of Data#members implies a megamorphic call
  inside, so it seems best to avoid relying on its existence.
…nymous

* It would be "#<data  a=42>" (double space) instead of "#<data a=42>" (like #inspect).
* Only 2 cyclic tests are failing, with the ... in a slightly different place in the output.
@eregon
Copy link
Member Author

eregon commented Jan 11, 2024

No review in a while, I'll merge this, it seems an obvious improvement.

@eregon eregon merged commit e35e32f into ruby:master Jan 11, 2024
@nobu
Copy link
Member

nobu commented Oct 4, 2025

This causes a warning with ruby 2.7.

$ ruby2.7 -w -e 'gem "pp"; require "pp"'
/opt/local/lib/ruby2.7/gems/2.7.0/gems/pp-0.6.2/lib/pp.rb:487: warning: constant ::Data is deprecated

defined? does not suppress warnings.

@nobu nobu mentioned this pull request Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants