Guarantee level_override exists #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsbt
reviewed
Aug 20, 2024
| SEV_LABEL[severity] || 'ANY' | ||
| end | ||
|
|
||
| def level_override |
There was a problem hiding this comment.
Can you comment that reason to extract level_override as method at this place?
4449bce to
a114504
Compare
Some Ruby apps subclass Logger without running the superclass constructor, which means that `@level_override` isn't initialized properly. This can be fixed in some cases, but the gem should maintain backwards compatibility.
a114504 to
3246f38
Compare
|
Sorry about the force-pushes; didn't realize I'd used the wrong email on the commits. |
|
when can we expect 1.6.1? without this aws lambda runtime breaks with the latest version of activesupport which now depends on logger rails/rails@d9adf17 |
|
@hsbt If there's anything additional I need to do, please let me know. |
This sounds like a definite bug obviously. |
nobu
added a commit
that referenced
this pull request
Feb 14, 2025
Warn wrong code, #100: > Some Ruby apps subclass Logger without running the superclass > constructor, which means that `@level_override` isn't initialized > properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Ruby apps subclass Logger without running the superclass constructor, which means that
@level_overrideisn't initialized properly. This can be fixed in some cases, but the gem should maintain backwards compatibility.My repro is from using Chef v12, but this should also address #99.