Skip to content

Fix Fiddle::Handle.new for a missing library in the FFI backend #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix Fiddle::Handle.new for a missing library in the FFI backend #156

merged 1 commit into from
Oct 18, 2024

Conversation

@eregon
Copy link
Member

@eregon eregon commented Oct 18, 2024

@eregon eregon requested a review from kou October 18, 2024 10:33
@eregon eregon mentioned this pull request Oct 18, 2024
Closed
@eregon eregon force-pushed the ffi-fix-handle-initialize branch from 06f7d08 to 871a6ad Compare October 18, 2024 10:36
@eregon eregon force-pushed the ffi-fix-handle-initialize branch from 871a6ad to 96ac4aa Compare October 18, 2024 10:39
@kou kou merged commit eea9fd0 into master Oct 18, 2024
102 checks passed
@kou kou deleted the ffi-fix-handle-initialize branch October 18, 2024 12:52
@kou
Copy link
Member

kou commented Oct 18, 2024

Good catch.

@headius
Copy link

headius commented Oct 22, 2024

Thank you for the fix. I have confirmed it locally using fiddle 1.1.4 and JRuby 10. The reline issue is gone.

hsbt pushed a commit to hsbt/ruby that referenced this pull request Oct 25, 2024
@eregon @hsbt
[ruby/fiddle] Fix Fiddle::Handle.new for a missing library in the
011a916 
FFI backend
(ruby/fiddle#156)

* From ruby/reline#766 (comment)

ruby/fiddle@eea9fd0cc4
hsbt pushed a commit to hsbt/ruby that referenced this pull request Oct 25, 2024
@eregon @hsbt
[ruby/fiddle] Fix Fiddle::Handle.new for a missing library in the
5f13957 
FFI backend
(ruby/fiddle#156)

* From ruby/reline#766 (comment)

ruby/fiddle@eea9fd0cc4
hsbt pushed a commit to hsbt/ruby that referenced this pull request Oct 26, 2024
@eregon @hsbt
[ruby/fiddle] Fix Fiddle::Handle.new for a missing library in the
a312a79 
FFI backend
(ruby/fiddle#156)

* From ruby/reline#766 (comment)

ruby/fiddle@eea9fd0cc4
hsbt pushed a commit to ruby/ruby that referenced this pull request Oct 26, 2024
@eregon @hsbt
[ruby/fiddle] Fix Fiddle::Handle.new for a missing library in the
346085e 
FFI backend
(ruby/fiddle#156)

* From ruby/reline#766 (comment)

ruby/fiddle@eea9fd0cc4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou Awaiting requested review from kou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eregon @kou @headius