[Fix #14445] Fix false positives for Lint/UselessAssignment with for loops when the variable is referenced in the collection
#14458
+34
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Aug 18, 2025
lib/rubocop/cop/variable_force.rb
Outdated
| @@ -243,6 +243,11 @@ def process_loop(node) | |||
| condition_node, body_node = *node | |||
| process_node(body_node) | |||
| process_node(condition_node) | |||
| elsif node.for_type? | |||
| # In `for foo in bar` the rightmost expression is evaluated first | |||
There was a problem hiding this comment.
That's just my two cents:
Suggested change
| # In `for foo in bar` the rightmost expression is evaluated first | |
| # In `for item in items` the rightmost expression is evaluated first. |
There was a problem hiding this comment.
Sure, I changed it
27eea08 to
4f8b2a4
Compare
…with `for` loops when the variable is referenced in the collection In a for-style loop, the children don't appear in the order that they actually execute.
4f8b2a4 to
1231fea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14445
In a for-style loop, the children don't appear in the order that they actually execute.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.