-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Merge :integration_tests:agp:testsupport into :integration_tests:agp
#9778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge :integration_tests:agp:testsupport into :integration_tests:agp
#9778
Conversation
|
@MGaetan89 Great to know this good news, could you share the AGP link of this feature? |
|
@MGaetan89 I think you can run unit-tests locally. |
It's my understanding of the last comment in the issue that was in the test comment: https://issuetracker.google.com/issues/127986458#comment22
Yes, I can 🙂 |
1b34d7d to
38fdda3
Compare
Looks like there are some dependencies issue? |
AGP is now able to merge test manifests, so it is no longer needed to have two modules.
38fdda3 to
742186e
Compare
|
The build is passing now 👍🏻 But is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, it works.
Merging this as-is, since it's already an improvement. @utzcoz @hoisie what do you think about removing the |
|
@MGaetan89 IIRC, there are some modules use TestActivity of agp module in tests . If we can confirm that other modules don't depend on agp module, and we don't need extra basic tests, I prefer to deleting agp module. |
|
I'll check again, but I didn't see any module depending on |
This commit removes the `:integration_tests:agp` module. Since the merge of robolectric#9778, it's no longer meaningful to have it.
This commit removes the `:integration_tests:agp` module. Since the merge of #9778, it's no longer meaningful to have it.
AGP is now able to merge test manifests, so it is no longer needed to have two modules.