Update SDK in test resources script and regenerate. #9348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/build-resources.sh is used to build the robolectric test resources binary. Recent changes broke ShadowActivityTest on gradle since they made modifications to the test AndroidManifest.xml which were not present in the binary. In addition an earlier change that added 'enableOnBackInvokedCallback' prevented the build-resources.sh from working at all, since that field was added in android SDK 34, but the script was still using android-28. This commit modifies the script to use aapt 34 and SDK 34, fail fast on errors, and regenerates the test resources. PiperOrigin-RevId: 655747577
a32bb0a to
f29bd94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SDK in test resources script and regenerate.
scripts/build-resources.sh is used to build the robolectric test
resources binary. Recent changes broke ShadowActivityTest on gradle
since they made modifications to the test AndroidManifest.xml which
were not present in the binary.
In addition an earlier change that added 'enableOnBackInvokedCallback' prevented
the build-resources.sh from working at all, since that field was added in android
SDK 34, but the script was still using android-28.
This commit modifies the script to use aapt 34 and SDK 34, fail fast on errors,
and regenerates the test resources.