Retry middleware #281
Open
Retry middleware #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The RequestSchedulerInterface was not registered as a singleton/shared in the dependency injection container. Because of this, the Engine received one instance of the scheduler, while the RetryMiddleware received a completely different, new instance. As a result, they operated with separate queues.
ksassnowski
requested changes
Aug 20, 2025
| 'retryOnStatus' => [500, 502, 503, 504], | ||
| 'maxRetries' => 3, | ||
| 'initialDelay' => 1000, | ||
| 'delayMultiplier' => 2.0, |
There was a problem hiding this comment.
I would prefer if we combined initialDelay and delayMultiplier into a single backoff option that takes an array of integers.
So a backoff of [1, 5, 10] would mean the first retry happens after one second, the second after 5, the third after 10 seconds and 10 seconds for every subsequent request if maxRetries is greater than 3.
|
Thanks for the PR! Looks good overall but I have a few comments that need to be addressed first. Please check them out when you find the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.