Skip to content

Use polymorphic variant for Platform.os #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2022
Merged

Use polymorphic variant for Platform.os #771

merged 1 commit into from
Oct 5, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Sep 15, 2022

While we are at it, here is another breaking change that we could release with the ReScript 10 version.

Since polymorphic variants are compiled to strings, we can make Platform.os a polymorphic variant, enabling pattern matching on it.

@cknitt cknitt added this to the 0.70 / rescript 10 milestone Sep 15, 2022
@cknitt cknitt requested a review from MoOx September 15, 2022 17:20
MoOx
MoOx approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@MoOx MoOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! Thanks again !

@MoOx MoOx merged commit b189fbc into main Oct 5, 2022
@MoOx MoOx deleted the platform-polyvar branch October 5, 2022 13:26
MoOx added a commit that referenced this pull request Oct 5, 2022
@MoOx
Merge branch 'main' into rescript-10
443e365 
* main:
  Use polymorphic variant for Platform.os (#771)
  Get rid of @string/@int for polyvars (#770)
@cknitt cknitt mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoOx MoOx MoOx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.70 / rescript 10
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @MoOx