Add Accept header (required by some JSON API implementations) #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very fine @matiaszanolli. Will add this to 1.4.1 milestone. Should be pushed within the week. |
|
1.4.1 now published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a small detail, but in some cases it makes the whole library unusable.
Some implementations of the
fetchAPI send anAccept: */*parameter, which doesn't work well with many APIs (such as Flask and Tornado JSON API implementations).According to the JSON API specification there shouldn't be any issues caused by sending this header in every request, and it seems to solve the problem.
Maybe it would be useful to be able to edit the default headers for fetch calls in a future release.