Expose node address to failed node detectors#7230
Open
rahulrane50 wants to merge 1 commit into
Open
Conversation
rahulrane50
force-pushed
the
rrane_failed_detector_address_tagging
branch
2 times, most recently
from
June 30, 2026 17:07
ce4ade1 to
ba22251
Compare
Signed-off-by: Rahul Rane <rahulrane50@gmail.com>
rahulrane50
force-pushed
the
rrane_failed_detector_address_tagging
branch
from
July 8, 2026 16:54
ba22251 to
3779030
Compare
Contributor
Author
|
@mrniko gentle ping on this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a follow-up observability hook for custom failed-node detectors. [issue]
This builds on the per-node detector copy fix in #7226. Once every copied
RedisClientConfighas an independent detector instance, Redisson can assign the Redis nodeaddress to that detector so custom wrappers can attribute/log the node they are observing.
Changes:
FailedNodeDetector.setNodeAddress(InetSocketAddress).RedisURIwhen the resolved address is not set.FailedNodeDetectorCopyTest.Depends on #7226.
Test:
JAVA_HOME=/Library/Java/JavaVirtualMachines/amazon-corretto-21.jdk/Contents/Home mvn -pl redisson -Punit-test -Dmaven.compiler.testRelease=21 -Dmaven.compiler.testSource=21 -Dmaven.compiler.testTarget=21 -Dtest=org.redisson.client.FailedNodeDetectorCopyTest test