Minimal fix for PHP 8 #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@remicollet Thanks! Is the same bug also present in |
|
@WyriHaximus in react/http, another fix is already applied |
clue
reviewed
Apr 7, 2021
There was a problem hiding this comment.
@remicollet Thanks for the update to support PHP 8, changes LGTM! 
The change itself is indeed very similar to reactphp/http#391, so I agree it makes sense to merge as-is even if this component has been deprecated (#152 / #153).
clue
approved these changes
Apr 7, 2021
|
@remicollet Ok awesome! |
WyriHaximus
approved these changes
Apr 7, 2021
|
Just released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid TypeError when overflow to float
Don't know if it worth to be fixed as deprecated component... BTW, minor patch