docs: mention Settings would be the route an app would be displaying for listed JS state #1105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for react-navigation-docs ready! 🔨 Explore the source changes: fca5bd1 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-navigation-docs/deploys/61de9d6a1f03f70008a4e569 😎 Browse the preview: https://deploy-preview-1105--react-navigation-docs.netlify.app |
…for listed JS state Further flesh out which route an app is displayed that would correspond to the navigation state represented by the listed JavaScript object. For example, it might not be immediately obvious to a newcomer that among the 2 routes of `Home` and `Settings`, it would be the `Settings` route that is displayed, and not `Home`. Signed-off-by: Ray Chuan Tay <rtay@vmware.com>
c515b1b to
fca5bd1
Compare
a2a5d9e to
fcb5e31
Compare
65c6448 to
df873a5
Compare
a739841 to
35a6db3
Compare
7dbaa57 to
9e2af9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ ME PLEASE!
TL;DR: Make sure to add your changes to versioned docs
Thanks for opening a PR!
The docs cover several versions of
react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").Please make sure that the edit you're making in
docs/file-you-edited.mdis also included in the file for the correct version, eg./versioned_docs/version-3.x/file-you-edited.mdfor version 3. If such file doesn't exist, please create it. 👍Hi there, this change further fleshes out which route is displayed by an app that would correspond to the navigation state represented by the listed JavaScript object. For example, it might not be immediately obvious to a newcomer that among the 2 routes of
HomeandSettings, it would beSettingsthat is displayed, and notHome.