Improve reported error calls throughout the package #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
reviewed
Nov 15, 2022
Comment on lines
+9
to
+10
| ! `.i` has an incorrect size. | ||
| x It must have size 1, not 2. |
There was a problem hiding this comment.
Suggested change
| ! `.i` has an incorrect size. | |
| x It must have size 1, not 2. | |
| ! `.i` must be size 1, not 2. |
Comment on lines
+20
to
+21
| ! `.i` must be in ascending order. | ||
| i It is not ascending at locations: 2. |
There was a problem hiding this comment.
Suggested change
| ! `.i` must be in ascending order. | |
| i It is not ascending at locations: 2. | |
| i In location: 2. | |
| ! `.i` must be in ascending order. |
Comment on lines
+70
to
+71
| ! `.i` cannot be `NA`. | ||
| i It is `NA` at locations: 2. |
There was a problem hiding this comment.
Suggested change
| ! `.i` cannot be `NA`. | |
| i It is `NA` at locations: 2. | |
| i In location: 2. | |
| ! `.i` cannot be `NA`. |
Comment on lines
+29
to
+30
| ! `i` has an incorrect type. | ||
| x It must inherit from Date, POSIXct, or POSIXlt, not numeric. |
There was a problem hiding this comment.
Suggested change
| ! `i` has an incorrect type. | |
| x It must inherit from Date, POSIXct, or POSIXlt, not numeric. | |
| ! `i` must inherit from Date, POSIXct, or POSIXlt, not numeric. |
This was referenced Nov 15, 2022
|
Tracking improvements to error messages in general in #188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168
Not currently passing the error call through to C yet, as that is currently too much work for what it would be worth. I think most of the main error paths have been improved anyways