Skip to content

Enumerated shape #13613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enumerated shape #13613

wants to merge 3 commits into from

Conversation

metascroy
Copy link
Contributor

Summary

This adds enumerated shape support for ExecuTorch's CoreML backend.

The CoreML backend supports dynamic shapes for the CPU/GPU. This enables enumerated shapes to support limit dynamism on the ANE.

These are done via compile specs:

enumerated_shapes = {"x": [[3, 5, 10], [4, 6, 10]], "y": [[3, 11], [5, 11]]}
...
compile_specs.append(
    CoreMLBackend.generate_enumerated_shapes_compile_spec(
        ep,
        enumerated_shapes,
    )
)
partitioner = CoreMLPartitioner(compile_specs=compile_specs)
delegated_program = executorch.exir.to_edge_transform_and_lower(
    ep,
    partitioner=[partitioner],
)

At runtime, one of the enumerated shapes must be supplied, or an error will occur.

Test plan

New E2E tests

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13613

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit be3dda2 with merge base 3db27cd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 22, 2025
@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D80848324.

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@metascroy metascroy requested a review from YifanShenSZ August 22, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

@YifanShenSZ YifanShenSZ Awaiting requested review from YifanShenSZ

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metascroy @facebook-github-bot