Switch from print_exported_headers to CMake's installed headers in scripts/build_apple_frameworks.sh #13559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13559
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 7f0e6fc with merge base 335de46 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Aug 20, 2025
…ripts/build_apple_frameworks.sh This removes the need to use Buck in this script. The previous PR (#13485) adds enforcement that we don't install non-public headers from CMake. I built the frameworks before and after. Here is a diff of all headers present in the frameworks: https://gist.github.com/swolchok/70647b551da7827a9cbdb083fad1e209 Generally, we now include more headers than before. The only header we used to include that we no longer include is schema/extended_header.h. It looks like we are not including the rest of the headers for the PTE schema anyway, so I propose that we fix installation of the schema headers separately. ghstack-source-id: 626397b ghstack-comment-id: 3207551649 Pull-Request: #13559
This was referenced Aug 20, 2025
|
There are a lot of headers for the code not shipped with the executorch runtime framework, so anyone using them by mistake will run into missing symbols error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to use Buck in this script. The previous PR (#13485) adds enforcement that we don't install non-public headers from CMake.
I built the frameworks before and after. Here is a diff of all headers
present in the frameworks:
https://gist.github.com/swolchok/70647b551da7827a9cbdb083fad1e209
Generally, we now include more headers than before. The only header we
used to include that we no longer include is
schema/extended_header.h. It looks like we are not including the rest
of the headers for the PTE schema anyway, so I propose that we fix
installation of the schema headers separately.