Skip to content

NXP backend: Add implementation of Tanh operator converter #13510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NXP backend: Add implementation of Tanh operator converter #13510

wants to merge 1 commit into from

Conversation

MartinPavella
Copy link
Contributor

@MartinPavella MartinPavella commented Aug 19, 2025 •
edited by pytorch-bot bot
Loading

Summary

This PR adds delegation support for the aten.tanh operator.

Test plan

Unit tests provided in backends/nxp/tests/ir/converter/node_converter/test_tanh_converter.py.

cc @digantdesai @JakeStevens @robert-kalmar

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13510

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 3 Unrelated Failures

As of commit ac9c7f4 with merge base 85e5b6e (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 19, 2025
@MartinPavella
Copy link
Contributor Author

@pytorchbot label "module: nxp" "release notes: nxp"

@pytorch-bot pytorch-bot bot added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Aug 19, 2025
@robert-kalmar robert-kalmar self-requested a review August 20, 2025 12:27
robert-kalmar
robert-kalmar requested changes Aug 20, 2025
View reviewed changes
@MartinPavella MartinPavella force-pushed the upstream/main-nxp/EIEX-456-upstream-support-for-tanh-operator branch from 7295ce4 to ac9c7f4 Compare August 20, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

@digantdesai digantdesai Awaiting requested review from digantdesai

@robert-kalmar robert-kalmar Awaiting requested review from robert-kalmar

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinPavella @robert-kalmar