Skip to content

Qwen and Phi-4-Mini targets #13449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2025
Merged

Qwen and Phi-4-Mini targets #13449

merged 2 commits into from
Aug 19, 2025
+8 −13

Conversation

rohansjoshi
Copy link
Contributor

Summary: Targets for Qwen 3, Phi-4-Mini

Reviewed By: cccclai

Differential Revision: D80015307

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13449

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit b98860b with merge base bba378c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 15, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80015307

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

cccclai
cccclai approved these changes Aug 15, 2025
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jackzhxng
jackzhxng approved these changes Aug 15, 2025 •
edited
Loading
View reviewed changes
examples/models/llama/export_llama_lib.py
elif model_name == "phi_4_mini":
from executorch.examples.models.phi_4_mini import ( # pyre-ignore[21]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, we needed these because the internal linter was being weird

rohansjoshi added a commit to rohansjoshi/executorch that referenced this pull request Aug 17, 2025
@rohansjoshi @facebook-github-bot
Qwen and Phi-4-Mini targets (pytorch#13449)
fdb13f8 
Summary:

Targets for Qwen 3, Phi-4-Mini

Reviewed By: jackzhxng, cccclai

Differential Revision: D80015307
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80015307

rohansjoshi added a commit to rohansjoshi/executorch that referenced this pull request Aug 17, 2025
@rohansjoshi @facebook-github-bot
Qwen and Phi-4-Mini targets (pytorch#13449)
b7140bc 
Summary:
Pull Request resolved: pytorch#13449

Targets for Qwen 3, Phi-4-Mini

Reviewed By: jackzhxng, cccclai

Differential Revision: D80015307
@rohansjoshi @facebook-github-bot
Qwen and Phi-4-Mini targets (pytorch#13449)
c56a053 
Summary:

Targets for Qwen 3, Phi-4-Mini

Reviewed By: jackzhxng, cccclai

Differential Revision: D80015307
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80015307

@facebook-github-bot
Copy link
Contributor

@rohansjoshi has imported this pull request. If you are a Meta employee, you can view this in D80015307.

@rohansjoshi rohansjoshi merged commit cc88b03 into pytorch:main Aug 19, 2025
104 of 105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai approved these changes

@jackzhxng jackzhxng jackzhxng approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rohansjoshi @facebook-github-bot @cccclai @jackzhxng