Skip to content

Summary: Add MCU model script to validate and run the models #13439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 19, 2025

Conversation

psiddh
Copy link
Contributor

@psiddh psiddh commented Aug 14, 2025

Test Plan:
See pre-requisite section in the script

a. examples/arm/run_mcu_models_fvp.sh --target=ethos-u85-128 // To run all models
b. examples/arm/run_mcu_models_fvp.sh --target=ethos-u85-128 --models=edsr // To run specific model

════════════════════════════════════════════════════════════════
🏁 MCU MODEL VALIDATION SUMMARY - TARGET: ethos-u85-128
════════════════════════════════════════════════════════════════

mv2 : ✅ Passed
mv3 : ✅ Passed
lstm : ✅ Passed
resnet18 : ✅ Passed

@psiddh psiddh requested a review from digantdesai as a code owner August 14, 2025 22:10
Copy link

pytorch-bot bot commented Aug 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13439

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Pending

As of commit 8865916 with merge base 31e13b0 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Test Plan:
See pre-requisite section in the script

a. examples/arm/run_mcu_models_fvp.sh --target=ethos-u85-128 // To run
all models
b. examples/arm/run_mcu_models_fvp.sh --target=ethos-u85-128
--models=lstm // To run specific model

Reviewers:

Subscribers:

Tasks:

Tags:
Comment on lines +12 to +15
# a. Setup Conda environment / venv
# b. ./install_executorch.sh --clean ; ./install_executorch.sh --editable;
# c. examples/arm/setup.sh --i-agree-to-the-contained-eula;
# d. source examples/arm/ethos-u-scratch/setup_path.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: point to the webpage, this may get outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree! Will update this in next iteration

set -u

# Valid targets for MCU model validation
VALID_TARGETS=(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need so many macs variants?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove unnecessary variants in next iteration

# Available models (on FVP)
AVAILABLE_MODELS=(mv2 mv3 lstm resnet18)
# Add the following models if you want to enable them later (atm they are not working on FVP)
# edsr w2l ic3 ic4 resnet50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you debug why? Just curious not a blocker for this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly it is the size of these models running on FVP, Need to debug it further


echo "🎯 MCU Model Validation - Target: $TARGET"
echo "📋 Processing models: ${MODELS[*]}"
echo "🔧 Mode: Portable Kernels (No Delegation)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have non-portable kernels, if we want to extend the "mode" in the future.

psiddh and others added 2 commits August 19, 2025 07:32
Co-authored-by: Digant Desai <digantdesai@meta.com>
@psiddh psiddh merged commit bf2f52b into pytorch:main Aug 19, 2025
103 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants