Remove other extensions' source files from EXTENSION_TRAINING_SRCS and TRAIN_XOR_SRCS #13433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swolchok
added a commit
that referenced
this pull request
Aug 15, 2025
…d TRAIN_XOR_SRCS Looks like this was an artifact of improperly specified deps in (now deleted) cmake_deps.toml. extension/training/CMakeLists.txt already has the relevant dependencies, so we should be able to just remove these. ghstack-source-id: 345e5d1 ghstack-comment-id: 3189839323 Pull-Request: #13433
GregoryComer
approved these changes
Aug 15, 2025
This was referenced Aug 18, 2025
|
noting CI looks good |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
|
again noting that CI looks good, again need to rebase because of spurious conflicts, thanks ghstack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this was an artifact of improperly specified deps in (now deleted) cmake_deps.toml. extension/training/CMakeLists.txt already has the relevant dependencies, so we should be able to just remove these.