Disallow runtime shutdown when the Python error indicator is set #1780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it may lead to unpredictable behavior
|
Couldn't we just clear it instead? |
|
@filmor that would be silent information loss. |
|
This way will probably lead to a lot more unwanted behaviour in that a program that ends with |
|
@filmor if they are at this point, they already have an unhandled exception. Generally speaking it is better to crash, than to try to close resources as you might persist a corrupted state and not get notified about it at all. |
|
Hmm, I'll tentatively agree with this, let's see whether someone complains :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Shutting down runtime when the Python error indicator is set has unpredictable behavior.
Checklist
CHANGELOG