Skip to content

Conversation

lostmsu
Copy link
Member

@lostmsu lostmsu commented Apr 9, 2022

Extension types were missed in #1758

What does this implement/fix? Explain your changes.

Clears weakref list in extension type instances when they are destroyed

According to official documentation for defining extension types, if they are to support weak references, they must clear weak reference list associated with the instance in tp_clear.

Extension types were missed in pythonnet#1758 ( 50da522 )
@lostmsu lostmsu requested a review from filmor April 9, 2022 20:59
@filmor filmor merged commit 86c6a7f into pythonnet:master Apr 10, 2022
@lostmsu lostmsu deleted the weakref/ext branch April 10, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants