Skip to content

Allow dynamic PyObject conversion to IEnumerable #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Allow dynamic PyObject conversion to IEnumerable #1697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/embed_tests/dynamic.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Collections.Generic;
using System.Text;
using NUnit.Framework;
using Python.Runtime;
Expand Down Expand Up @@ -126,5 +127,15 @@ public void PassPyObjectInNet()
// Compare in .NET
Assert.IsTrue(sys.testattr1.Equals(sys.testattr2));
}

// regression test for https://github.com/pythonnet/pythonnet/issues/1680
[Test]
public void ForEach()
{
dynamic pyList = PythonEngine.Eval("[1,2,3]");
var list = new List<int>();
foreach (int item in pyList)
list.Add(item);
}
}
}
6 changes: 6 additions & 0 deletions src/runtime/PythonTypes/PyObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,6 +1296,12 @@ public override bool TryConvert(ConvertBinder binder, out object? result)
return converted;
}

if (binder.Type == typeof(System.Collections.IEnumerable) && this.IsIterable())
{
result = new PyIterable(this.Reference);
return true;
}

return false;
}

Expand Down