Skip to content

Conversation

lostmsu
Copy link
Member

@lostmsu lostmsu commented Jan 4, 2022

What does this implement/fix? Explain your changes.

Prior to this change if method had multiple generic overloads, only 1 of them could be matched (whichever one reflection would return first)

Now MethodBinder.MatchParameters returns all matching generic overloads, not just the first one.

Does this close any currently open issues?

fixes #1522

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change

Prior to this change if method had multiple generic overloads, only 1 of them could be matched (whichever one reflection would return first)

Now MethodBinder.MatchParameters returns all matching generic overloads, not just the first one.

fixes pythonnet#1522
@lostmsu lostmsu merged commit fabb22c into pythonnet:master Jan 5, 2022
@lostmsu lostmsu deleted the bugs/1522 branch January 5, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"TypeError: No method matches given arguments" error for a virtual method with a template parameter
2 participants