Test for non-ASCII encoded method name #1329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a Windows-specific issue. Do you have a Windows machine to work on it? I can pick it up otherwise. |
|
I have one, I'll look into this tomorrow. |
bad8fb8 to
45a76fc
Compare
lostmsu
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Use UTF8 explicitly to marshal strings towards Python C-API functions ending in
String.Does this close any currently open issues?
#979.
Any other comments?
Runs fine for me both with 2.5.1 as well as current master on Linux.
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG