Skip to content

Conversation

aelkheir
Copy link
Member

Also refactors name(), fullname(), link() convenience properties of some Telegram Objects.

continues work from #4713
I've skipped utilizing the new helpers in bot.name() and bot.link() not to complicate the type vars.

I could separate the refactor from the new functionality if that's preferred.

david-shiko and others added 8 commits March 7, 2025 04:31
…sts for it; Replace `user` and `shared_user` correspond properties implementations on a new functinos.
…rnames.py` implementation; Note: `full_name` and `effective_name` can not be easily replaced in the such way
…lved; Slots tests failed for Protocol class.
@aelkheir aelkheir mentioned this pull request Jul 27, 2025
@aelkheir aelkheir added the 📋 pending-review work status: pending-review label Jul 27, 2025
@aelkheir aelkheir changed the title Add convenience properties to SharedUser and SharedUser Add convenience properties to SharedUser and ChatShared Jul 27, 2025
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! just one minor nitpick in the chango fragment :)

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another typo in the changelog :) feature looks good otherwise

@harshil21 harshil21 added 🔌 enhancement pr description: enhancement and removed 📋 pending-review work status: pending-review labels Jul 28, 2025
@Bibo-Joshi Bibo-Joshi merged commit 6752547 into master Jul 28, 2025
32 checks passed
@Bibo-Joshi Bibo-Joshi deleted the user-like-properties branch July 28, 2025 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 enhancement pr description: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants