Skip to content

Conversation

Poolitzer
Copy link
Member

Quick fix, just surprised mypy didn't catch it

@lemontree210 lemontree210 changed the title Fix: Fix return value of create_forum_topic shortcut Fix: Fix return value of create_forum_topic shortcut Nov 22, 2022
@lemontree210
Copy link
Member

Just in case: I could also have added the following bit to docstring, but I see that it wasn't done anywhere in shortcut methods for respective methods in Bot.

Raises: 
    :class:`telegram.error.TelegramError`

@harshil21
Copy link
Member

@lemontree210 not needed since it's there in the original

@harshil21 harshil21 added the ⚙️ type-hinting affected functionality: type-hinting label Nov 22, 2022
@harshil21 harshil21 added this to the v20.0a6 milestone Nov 22, 2022
@Bibo-Joshi Bibo-Joshi merged commit 8c03f0e into master Nov 23, 2022
@Bibo-Joshi Bibo-Joshi deleted the fix_return_value branch November 23, 2022 12:21
@Poolitzer Poolitzer mentioned this pull request Nov 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚙️ type-hinting affected functionality: type-hinting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants